Allow running non-steam scummvm games #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is outside the scope of the project but a small change allows people to use steam to launch native non-steam scummvm games.
e.g.
Then just relaunch steam and set the game compatibility to roberta
Even without this change, I think there needs to be a change to the handling of what to do if guess_game_install_dir fails. At the moment it returns None which then makes it fall over when it tries to do
install_dir = install_dir.replace('\\ ', ' ')
Setting install_dir to cwd seems like a ok default and also makes this work with non steam games as I said above 😄