Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add range to-string api & fix data-validation api #4325

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Dec 17, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 17, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  395b7b5
info  For more information, see full report

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.46%. Comparing base (7e6e97c) to head (395b7b5).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ts-data-validation/src/facade/f-data-validation.ts 0.00% 13 Missing ⚠️
...kages/sheets-data-validation/src/facade/f-range.ts 0.00% 2 Missing ⚠️
...ages/sheets-data-validation/src/facade/f-univer.ts 0.00% 2 Missing ⚠️
packages/sheets/src/facade/f-range.ts 0.00% 2 Missing ⚠️
...s/sheets-data-validation/src/facade/f-worksheet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4325      +/-   ##
==========================================
+ Coverage   33.44%   33.46%   +0.01%     
==========================================
  Files        2509     2509              
  Lines      129496   129485      -11     
  Branches    28972    28968       -4     
==========================================
+ Hits        43312    43333      +21     
+ Misses      86184    86152      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 changed the title feat(sheets): add range to-string api feat(facade): add range to-string api & fix data-validation api Dec 18, 2024
@weird94 weird94 merged commit 47773f8 into dev Dec 18, 2024
9 checks passed
@weird94 weird94 deleted the feat/range-tostring branch December 18, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants