Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): menu align when select table cells #4127

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 22, 2024

close https://github.com/dream-num/univer-pro/issues/3431

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review November 22, 2024 12:27
@Jocs Jocs requested a review from jikkai as a code owner November 22, 2024 12:27
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 18 seconds
commit  9cc0487
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.76%. Comparing base (0d07c86) to head (9cc0487).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4127      +/-   ##
==========================================
- Coverage   33.76%   33.76%   -0.01%     
==========================================
  Files        2457     2457              
  Lines      127785   127787       +2     
  Branches    28614    28616       +2     
==========================================
  Hits        43141    43141              
- Misses      84644    84646       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Jocs Jocs changed the title fix(docs-ui): menu alin when select table cells fix(docs-ui): menu align when select table cells Nov 22, 2024
@oumomomo
Copy link

选中表格内容设置有序/无序列表&任务清单,工具栏未高亮
image

@univer-bot
Copy link

univer-bot bot commented Nov 22, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Select the table content to set ordered/unordered list & task list, and the toolbar is not highlighted.
image

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Nov 22, 2024
@Jocs Jocs added the qa:untested This PR is ready to be tested label Nov 22, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 22, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 23, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 23, 2024
@Jocs Jocs merged commit e1d7713 into dev Nov 23, 2024
9 checks passed
@Jocs Jocs deleted the fix/align-in-table branch November 23, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants