Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some case rich text style should convert to cell style #3975

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Nov 6, 2024

close https://github.com/dream-num/univer-pro/issues/2604

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested a review from yuhongz as a code owner November 6, 2024 09:43
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 6, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 40 seconds
commit  4c263fa
info  For more information, see full report

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 32.70%. Comparing base (39d0d46) to head (4c263fa).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...ets-ui/src/services/clipboard/html-to-usm/utils.ts 0.00% 16 Missing ⚠️
...ui/src/services/clipboard/html-to-usm/converter.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3975      +/-   ##
==========================================
+ Coverage   32.46%   32.70%   +0.24%     
==========================================
  Files        2427     2439      +12     
  Lines      126046   126542     +496     
  Branches    28196    28342     +146     
==========================================
+ Hits        40915    41380     +465     
- Misses      85131    85162      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 6, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 6, 2024
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybzky ybzky merged commit 47cae07 into dev Nov 6, 2024
9 checks passed
@ybzky ybzky deleted the fix-paste-convert-style branch November 6, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants