Test and allow failures against Rails master

[steveklabnik]

I think this is how this works, but I'm gonna submit it as a PR so that Travis tries to build it. 😉

If we're testing against ruby-head we should test against Rails master too. Will also help me expose bugs in Rails.

[steveklabnik]

Odd. GitHub doesn't show it as submitted, but: https://travis-ci.org/drapergem/draper/builds/4140218

[haines]

I think it's because hasn't started yet, still queued.

[haines]

I expect it is going to fail pretty rapidly on master, locally I got uninitialized constant ActiveModel::Validations in our fake AR::Base. I was going to have a look at fixing it but didn't get round to it.

[steveklabnik]

Yeah, I don't plan on making it pass immediately, but it will be good to track progress. Even once it's green, we should leave it in the failures: edge rails is pretty stable, but it'd suck if their build failures affected ours.

[steveklabnik]

... that said, it does look like my Travis syntax is correct.

[haines]

Yep indeed! The double-build issue is really annoying now that we're pumping out 12+ jobs per build, it fills up the queue pretty fast! I filed an issue over at travis-ci/travis-ci#855 a couple of days ago but I don't think they've gotten to it yet.

[steveklabnik]

Your suspicion about the build stuff not appearing until it's queued is apparently correct. Neat.

[steveklabnik]

You are correct: https://travis-ci.org/drapergem/draper/jobs/4140234/#L89

[haines]

It looks like it works if you rip the guts out of our fake AR::Base and just do

module ActiveRecord
  class Base
  end
end

Turns out we don't need anything in there at all! (which is nice to know, since unit tests are supposed to be isolated!).

[haines]

Try that... poor Travis...

[steveklabnik]

😄

I was like HOW DID YOU GET THAT COMMIT IN THERE and then I remembered I created the branch on the main repo, and not on my own. 😉

Turns out we don't need anything in there at all! (which is nice to know, since unit tests are supposed to be isolated!).

Yeah, a lot of this is ooooold...

[haines]

I AM IN YOUR REPO 😈

Looks all good!

[steveklabnik]

🤘