Add placeholder for filename without extension #1833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
drakkan
reviewed
Dec 23, 2024
| @@ -796,6 +796,7 @@ func (p *EventParams) getStringReplacements(addObjectData, jsonEscaped bool) []s | |||
| "{{VirtualTargetPath}}", p.getStringReplacement(p.VirtualTargetPath, jsonEscaped), | |||
| "{{FsTargetPath}}", p.getStringReplacement(p.FsTargetPath, jsonEscaped), | |||
| "{{ObjectName}}", p.getStringReplacement(p.ObjectName, jsonEscaped), | |||
| "{{ObjectBaseName}}", p.getStringReplacement(strings.TrimSuffix(path.Base(p.ObjectName), path.Ext(p.ObjectName)), jsonEscaped), | |||
There was a problem hiding this comment.
p.ObjectName is already the path.Base of the virtual path. path.Ext is already computed as p.Extension
drakkan
reviewed
Dec 23, 2024
| @@ -921,6 +921,9 @@ <h3 data-i18n="actions.placeholders_modal_title" class="modal-title">Supported p | |||
| <p> | |||
| <span class="shortcut">{{`{{ObjectName}}`}}</span> => <span data-i18n="actions.placeholders_modal.object_name">File/directory name, for example "afile.txt" or provider object name.</span> | |||
| </p> | |||
| <p> | |||
| <span class="shortcut">{{`{{ObjectBaseName}}`}}</span> => <span data-i18n="actions.placeholders_modal.object_basename">Filename without extension, for example "afile" if the filename is "afile.txt".</span> | |||
There was a problem hiding this comment.
the translation must be added to the language files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a placeholder containing the filename without the extension.
Fixes #1828
Checklist for Pull Requests