Universal shebangs. Shellcheck fixes, globbing/expansion fixes, etc. #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Correct variables unused due to single quotes. Switch to /usr/bin/env bash
…lobbing/expansion
…d expansion. Should $cs_user have a '/' after it?
…/expansion. Consider moving functions to the top.
…154 errors for this file.
…t globbing/expansion. Combine redirects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common convention is also to remove the "*.sh" extension these days, to avoid confusion that these are traditional
shellfiles instead ofbash, as they are not wholly compatible.However, that would obviously involve going over every single reference to every single file to alter.