Install cleanup

[AngelofWoe]

Some small changes to follow some conventions

Shebang as #!/usr/bin/env bash queries the local environ PATH for the location of bash. This makes a script much more portable. However, if someone inserts a bash into PATH that isn't actually bash, some weird stuff can happen - but this is a problem of a user / malicious entity messing with something they should not.

Arrays are slightly safer than strings for globbing/expansion, while still allowing package managers to expand the array into separate installable packages.

[AngelofWoe]

Does not fix #1396. Skipping Bazzite and adding rpm-ostree as #1399 should be fine.

I don't think that ignoring SC2086 is ideal (I prefer using the arrays or a similar solution).

[AngelofWoe]

Also, if you wanted script_failure to (kind of) work. Although I don't think this ever got used.

function script_failure () {
    log_err "An error occurred: $( [ ! -z ${1} ] && echo \"on line ${1}\" || echo '(unknown)' )."
    log_err "Installation failed!"
    exit
}

[AngelofWoe]

Should fix #1396.

I'd rather default to install dependencies, even if Bazzite has them installed by base. A user might have uninstalled something. It shouldn't do any harm as rpm-ostree will just do nothing if all packages are installed already. For whatever reason, if all packages are already installed, rpm-ostree will only report the first in the list is. However, it does check the whole list.

I do note that running rpm-ostree upgrade will have the system want to reboot, if there's an actual upgrade (although it won't reboot automatically).