Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci fixes #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ci fixes #194

wants to merge 2 commits into from

Conversation

sergiy-petrov
Copy link

@sergiy-petrov sergiy-petrov commented Oct 28, 2024 •
edited
Loading

  • Some PHPStan fixes
  • Add testing against php 8.4

sergiy-petrov
sergiy-petrov commented Oct 28, 2024
View reviewed changes
phpstan.neon
@@ -8,6 +7,7 @@ parameters:
- '#Call to an undefined method DateTimeInterface::setTime\(\)#'
- '#Call to an undefined method DateTimeInterface::setTimezone\(\)#'
- '#Call to an undefined method DateTimeInterface::sub\(\)#'
- identifier: missingType.iterableValue
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

sergiy-petrov
sergiy-petrov commented Oct 28, 2024
View reviewed changes
src/Cron/AbstractField.php
@@ -139,6 +139,8 @@ public function isInIncrementsOfRanges(int $dateValue, string $value): bool
return false;
}

$step = (int)$step;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergiy-petrov