Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove phpstan/phpstan-webmozart-assert dependency #187

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Remove phpstan/phpstan-webmozart-assert dependency #187

merged 1 commit into from
Oct 9, 2024

Conversation

8ctopus
Copy link

@8ctopus 8ctopus commented Jun 11, 2024

@dragonmantank dragonmantank merged commit ac0925a into dragonmantank:master Oct 9, 2024
@dragonmantank
Copy link
Owner

Thanks!

@8ctopus 8ctopus deleted the remove-assert branch October 10, 2024 05:59
@VincentLanglet
Copy link

Why "webmozart/assert": "^1.0" is not removed from the require then ?

@8ctopus 8ctopus mentioned this pull request Oct 21, 2024
Merged
@8ctopus
Copy link
Author

8ctopus commented Oct 21, 2024

@VincentLanglet Thank you for noticing that actually there was still webmozart assert itself in addition to phpstan webmozart assert. I removed it completely in #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@8ctopus @dragonmantank @VincentLanglet