Fixed backward incompatible change in php8.2 #174
Conversation
…ive formats no longer accept multiple signs, e.g. +-2.
| $date = $this->timezoneSafeModify($date, "-{$distance} hours"); | ||
| $date = $this->timezoneSafeModify($date, (-$distance) . " hours"); |
There was a problem hiding this comment.
Accordingly to relative formats docs this should be "hours ago"
What you wrote is just different syntax, it is being interpreted the same way - see https://3v4l.org/KRVLH
There was a problem hiding this comment.
@mabar Yes, right, but it will work incorrect if $distance is negative.
For example if we are calling modify("--10 hours), we expect it like "+10 hours", but actually since php8.2 it will be working like "-10 hours": https://3v4l.org/X1XJd#v8.3.4
|
This discussion and PR actually caused me to go down another path, which seemed to end up being that Before I release a fix, could I get your thoughts on #181 as it will impact the overall solution? |
php8.2 has backward incompatible: number symbols in relative formats no longer accept multiple signs, e.g. +-2.
https://www.php.net/manual/en/migration82.incompatible.php