Improve nydusify build subcommand #721
Conversation
Fix a minor in Makefile for musl static build. Signed-off-by: Jiang Liu <[email protected]>
|
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21220 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
force-pushed
the
nydusify-build
branch
from
72acb28 to
dd51401
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21221 |
jiangliu
force-pushed
the
nydusify-build
branch
from
dd51401 to
8f607ec
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21222 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
force-pushed
the
nydusify-build
branch
from
8f607ec to
6cc206d
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21225 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
force-pushed
the
nydusify-build
branch
from
6cc206d to
a18d85c
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21226 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Fix several possible resource leakages. Signed-off-by: Jiang Liu <[email protected]>
jiangliu
force-pushed
the
nydusify-build
branch
from
a18d85c to
cb69660
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21238 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
requested review from
imeoer and
changweige
and removed request for
imeoer
| Usage: "Pack a directory to nydus bootstrap and blob", | ||
| Name: "build", | ||
| Aliases: []string{"pack"}, | ||
| Usage: "Build a Nydus image from a source directory", |
There was a problem hiding this comment.
It does not actually generate the image manifest, so maybe we can't say build a nydus image. :)
There was a problem hiding this comment.
How abot "Build a Nydus filesystem from a source directory"?
| Flags: []cli.Flag{ | ||
| &cli.StringFlag{ | ||
| Name: "source-dir", | ||
| Aliases: []string{"target-dir"}, // for compatibility | ||
| Required: true, | ||
| Usage: "The source directory of build target", | ||
| Usage: "Source directory to build image from", |
| &cli.BoolFlag{ | ||
| Name: "backend-push", | ||
| Value: false, | ||
| Usage: "Push Nydus blob to storage backend", | ||
| Usage: "Push generated Nydus image to storage backend", |
Improve help messages and fix a crash bug related to oss. Signed-off-by: Jiang Liu <[email protected]>
jiangliu
force-pushed
the
nydusify-build
branch
from
cb69660 to
a9a436f
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21459 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
LGTM |
Improve nydusify build subcommand and fix some resource leakages.