nydus-image: refactor subcommand "inspect" #675

YushuoEdge · 2022-08-13T12:43:52Z

The code for "nydus-image inspect" are refactored using standard API
in RAFS.

Signed-off-by: YushuoEdge [email protected]

anolis-bot · 2022-08-13T12:44:01Z

@YushuoEdge , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/18269

anolis-bot · 2022-08-13T12:50:47Z

@YushuoEdge , The CI test is completed, please check result:

Test Case		Test Result
merge-target-branch		✅ SUCCESS
build-docker-image		✅ SUCCESS
compile-nydus		✅ SUCCESS
compile-ctr-remote		✅ SUCCESS
compile-nydus-snapshotter		✅ SUCCESS
start-nydus-snapshotter-config-containerd		✅ SUCCESS
run-container-with-nydus-image		✅ SUCCESS

Congratulations, your test job passed!

liubogithub · 2022-08-15T00:55:51Z

@changweige can you please take a look?

changweige · 2022-08-15T01:53:05Z

@changweige can you please take a look?

Sure. will take a glance

changweige · 2022-08-17T01:54:17Z

I am experiencing this refactored tool but got the below error, which I think chunk info should be correctly shown about its blob id and chunk index in one blob.

Shall we continue reviewing the PR until they are fixed?

For symlink file:

Inspecting Rafs :> stat run
[2022-08-17 09:49:51.162030 +08:00] ERROR [error/src/error.rs:21] Error:
	"invalid chunk info"
	at rafs/src/metadata/direct_v6.rs:956
	note: enable `RUST_BACKTRACE=1` env to display a backtrace
Failed in executing command, No such file or directory (os error 2)

For regular file:

Inspecting Rafs :> stat btmp
[2022-08-17 09:52:57.778269 +08:00] ERROR [/home/gechangwei/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/log-panics-2.1.0/src/lib.rs:130] thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: NotFound, error: "No such file or directory (os error 2): rafs/src/metadata/direct_v6.rs:753" }': rafs/src/metadata/direct_v6.rs:1141
   0: backtrace::capture::Backtrace::create
   1: backtrace::capture::Backtrace::new

YushuoEdge · 2022-08-17T12:55:19Z

changweige

Sorry for that. I did not find the problem when I did test before. Maybe something went wrong when I rebase to master branch, please allow me to check again and revise.

anolis-bot · 2022-08-27T10:05:40Z

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/19319

anolis-bot · 2022-08-27T10:13:26Z

@YushuoEdge , The CI test is completed, please check result:

Test Case		Test Result
merge-target-branch		✅ SUCCESS
build-docker-image		✅ SUCCESS
compile-nydus		✅ SUCCESS
compile-ctr-remote		✅ SUCCESS
compile-nydus-snapshotter		✅ SUCCESS
start-nydus-snapshotter-config-containerd		✅ SUCCESS
run-container-with-nydus-image		✅ SUCCESS

Congratulations, your test job passed!

changweige · 2022-08-29T06:37:32Z

Please rebase your PR to get cargo deny passed

anolis-bot · 2022-08-29T14:57:15Z

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/19487

anolis-bot · 2022-08-29T15:24:59Z

@YushuoEdge , The CI test is completed, please check result:

Test Case		Test Result
merge-target-branch		✅ SUCCESS
build-docker-image		✅ SUCCESS
compile-nydus		✅ SUCCESS
compile-ctr-remote		✅ SUCCESS
compile-nydus-snapshotter		✅ SUCCESS
start-nydus-snapshotter-config-containerd		✅ SUCCESS
run-container-with-nydus-image		✅ SUCCESS

Congratulations, your test job passed!

bergwolf

Nice cleanup! Thanks! Is it possible to add some test cases in smoke? There are pre-built bootstrap files under tests/texture/bootstrap/ which can be used to test inspect as well.

bergwolf · 2022-08-16T16:32:21Z

src/bin/nydus-image/inspect.rs

@@ -882,7 +492,6 @@ impl Executor {
    prefetch:           Show prefetch table
    chunk OFFSET:       List basic info of a single chunk together with a list of files that share it
    icheck INODE:       Show path of the inode and basic information
-    index INDEX:        Show information about a file by its index


Indeed index is unneeded and it's fine to just drop it.

bergwolf · 2022-08-16T16:43:10Z

src/bin/nydus-image/inspect.rs

@@ -896,7 +505,7 @@ impl Prompt {
            print!("Inspecting Rafs :> ");
            std::io::stdout().flush().unwrap();

-            let mut input = String::new();
+            let mut input: String = String::new();


This looks unnecessary.

imeoer · 2022-09-16T02:38:57Z

Updates: @YushuoEdge is working on smoke testing and fixing. :)

The code for "nydus-image inspect" are refactored using standard API in RAFS. Signed-off-by: YushuoEdge <[email protected]>

anolis-bot · 2022-09-18T06:11:19Z

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21637

anolis-bot · 2022-09-18T06:16:20Z

@YushuoEdge , The CI test is completed, please check result:

Test Case		Test Result
merge-target-branch		✅ SUCCESS
build-docker-image		✅ SUCCESS
compile-nydus		❌ FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot · 2022-09-18T06:40:13Z

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21638

YushuoEdge · 2022-09-18T06:41:57Z

update:
The request_mode output of cmd stats, prefetch, blobs are used in smoke test.
More tests result can refer to: https://docs.google.com/document/d/115r90YmZmRPKxEz6WEfGHD6F6eylv4lQDe-7xd_pTUI/edit?usp=sharing

anolis-bot · 2022-09-18T06:49:43Z

@YushuoEdge , The CI test is completed, please check result:

Test Case		Test Result
merge-target-branch		✅ SUCCESS
build-docker-image		✅ SUCCESS
compile-nydus		✅ SUCCESS
compile-ctr-remote		✅ SUCCESS
compile-nydus-snapshotter		✅ SUCCESS
start-nydus-snapshotter-config-containerd		✅ SUCCESS
run-container-with-nydus-image		❌ FAIL

Sorry, your test job failed. Please get the details in the link.

We use the output result of request_mode for verification. In ./tests/texture/image-inspect/*.result, there stores the output result of executing cmd `nydus-image inspect -B ./tests/texture/bootstrap/image_v2.boot -R *` with `nydus-image` that has not been refactored. Then we load the result and compare them with result using the refactored `nydus-image` to do the smoke test. Signed-off-by: YushuoEdge <[email protected]>

anolis-bot · 2022-09-18T08:56:49Z

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21641

anolis-bot · 2022-09-18T09:06:06Z

@YushuoEdge , The CI test is completed, please check result:

Test Case		Test Result
merge-target-branch		✅ SUCCESS
build-docker-image		✅ SUCCESS
compile-nydus		✅ SUCCESS
compile-ctr-remote		✅ SUCCESS
compile-nydus-snapshotter		✅ SUCCESS
start-nydus-snapshotter-config-containerd		✅ SUCCESS
run-container-with-nydus-image		❌ FAIL

Sorry, your test job failed. Please get the details in the link.

imeoer · 2022-09-19T03:42:21Z

update: The request_mode output of cmd stats, prefetch, blobs are used in smoke test. More tests result can refer to: https://docs.google.com/document/d/115r90YmZmRPKxEz6WEfGHD6F6eylv4lQDe-7xd_pTUI/edit?usp=sharing

Thanks for adding the test case in smoke testing, it is difficult for us to cover all the tests of inspect command, a few basic checks are enough, what do you think? cc @changweige @bergwolf

bergwolf

Thanks a lot!

anolis-bot added the anolis_testing label Aug 13, 2022

anolis-bot added anolis_test_pass and removed anolis_testing labels Aug 13, 2022

YushuoEdge force-pushed the nydus-image/inspect branch from f219a1d to 4ff80f6 Compare August 27, 2022 10:05

anolis-bot added anolis_testing and removed anolis_test_pass labels Aug 27, 2022

anolis-bot added anolis_test_pass and removed anolis_testing labels Aug 27, 2022

YushuoEdge force-pushed the nydus-image/inspect branch from 4ff80f6 to 9194fe0 Compare August 29, 2022 14:55

anolis-bot added anolis_testing and removed anolis_test_pass labels Aug 29, 2022

YushuoEdge closed this Aug 29, 2022

YushuoEdge reopened this Aug 29, 2022

anolis-bot added anolis_test_pass and removed anolis_testing labels Aug 29, 2022

bergwolf reviewed Aug 30, 2022

View reviewed changes

bergwolf mentioned this pull request Aug 30, 2022

nydus-image inspect panic #705

Closed

nydus-image: refactor subcommand "inspect"

c4b51fa

The code for "nydus-image inspect" are refactored using standard API in RAFS. Signed-off-by: YushuoEdge <[email protected]>

YushuoEdge force-pushed the nydus-image/inspect branch from 9194fe0 to 117022f Compare September 18, 2022 06:09

anolis-bot added anolis_testing and removed anolis_test_pass labels Sep 18, 2022

anolis-bot added anolis_test_fail and removed anolis_testing labels Sep 18, 2022

YushuoEdge force-pushed the nydus-image/inspect branch from 117022f to 2ab5550 Compare September 18, 2022 06:38

anolis-bot added anolis_testing and removed anolis_test_fail labels Sep 18, 2022

anolis-bot added anolis_test_fail and removed anolis_testing labels Sep 18, 2022

YushuoEdge force-pushed the nydus-image/inspect branch from 2ab5550 to 57208ec Compare September 18, 2022 08:54

anolis-bot added anolis_testing and removed anolis_test_fail labels Sep 18, 2022

anolis-bot added anolis_test_fail and removed anolis_testing labels Sep 18, 2022

bergwolf approved these changes Sep 20, 2022

View reviewed changes

bergwolf merged commit 8aaeca9 into dragonflyoss:master Sep 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nydus-image: refactor subcommand "inspect" #675

nydus-image: refactor subcommand "inspect" #675

YushuoEdge commented Aug 13, 2022

anolis-bot commented Aug 13, 2022

anolis-bot commented Aug 13, 2022

liubogithub commented Aug 15, 2022

changweige commented Aug 15, 2022

changweige commented Aug 17, 2022

YushuoEdge commented Aug 17, 2022

anolis-bot commented Aug 27, 2022

anolis-bot commented Aug 27, 2022

changweige commented Aug 29, 2022

anolis-bot commented Aug 29, 2022

anolis-bot commented Aug 29, 2022

bergwolf left a comment

bergwolf Aug 16, 2022

bergwolf Aug 16, 2022

imeoer commented Sep 16, 2022

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

YushuoEdge commented Sep 18, 2022 •

edited

Loading

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

imeoer commented Sep 19, 2022

bergwolf left a comment

nydus-image: refactor subcommand "inspect" #675

nydus-image: refactor subcommand "inspect" #675

Conversation

YushuoEdge commented Aug 13, 2022

anolis-bot commented Aug 13, 2022

anolis-bot commented Aug 13, 2022

liubogithub commented Aug 15, 2022

changweige commented Aug 15, 2022

changweige commented Aug 17, 2022

YushuoEdge commented Aug 17, 2022

anolis-bot commented Aug 27, 2022

anolis-bot commented Aug 27, 2022

changweige commented Aug 29, 2022

anolis-bot commented Aug 29, 2022

anolis-bot commented Aug 29, 2022

bergwolf left a comment

Choose a reason for hiding this comment

bergwolf Aug 16, 2022

Choose a reason for hiding this comment

bergwolf Aug 16, 2022

Choose a reason for hiding this comment

imeoer commented Sep 16, 2022

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

YushuoEdge commented Sep 18, 2022 • edited Loading

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

anolis-bot commented Sep 18, 2022

imeoer commented Sep 19, 2022

bergwolf left a comment

Choose a reason for hiding this comment

YushuoEdge commented Sep 18, 2022 •

edited

Loading