builder: fix rafs v5 dir size for reproducible build #642
Conversation
|
@imeoer , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17540 |
|
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17541 |
|
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17542 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17545 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Since different filesystems may calculate different directory sizes, for RAFS v5, nydus needs to implement the directory size calculation itself to achieve reproducible builds on different hosts or filesystems. For RAFS v6, the directory size is calculated by actual entries. Signed-off-by: Yan Song <[email protected]>
|
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17553 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
| // for RAFS v5, nydus needs to implement the directory size calculation | ||
| // itself to achieve reproducible builds on different hosts or filesystems. | ||
| // For RAFS v6, the directory size is calculated by actual entries later. | ||
| fn set_v5_dir_size(fs_version: &RafsVersion, tree: &mut Tree) { |
There was a problem hiding this comment.
How about passing "RafsVersion" instead of "&RafsVersion"?
|
Let's it first and I will submit a following on PR to fix the minor refinements. |
Since different filesystems may calculate different directory sizes,
for RAFS v5, nydus needs to implement the directory size calculation
itself to achieve reproducible builds on different hosts or filesystems.
For RAFS v6, the directory size is calculated by actual entries.
Signed-off-by: Yan Song [email protected]