nydusd: fix race window in copen handler #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinXYin , a new test job has been submitted. Please wait in patience. The test job url: None |
|
@kevinXYin , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
Could you help elaborate further about the race window this PR is closing? |
changweige
reviewed
Aug 1, 2022
| let barrier = Arc::new(Barrier::new(2)); | ||
| Self::init_blobcache(fsblob, Arc::clone(&barrier)); | ||
| // make sure blob cache init thread get wlock before get first ondemand req | ||
| barrier.wait(); |
There was a problem hiding this comment.
Nit:
Some grammar mistakes with this comment sentence 😹
If the blobcache init thread was not scheduled immediately after creation, and an ondemand request arrived. The fscache handler may not wait for blobcache to be created and resault in eio. We should make sure the blobcache init thread gets wlock before user daemon receives first ondemand request. Fixes: 82f6712 ("nydusd: make copen always return right file size") Suggested-by: Jiang Liu <[email protected]> Signed-off-by: Xin Yin <[email protected]>
kevinXYin
force-pushed
the
init-blobcache-fix
branch
from
02ccfa0 to
5b7494c
Compare
|
@kevinXYin , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: None |
updated in commit message |
|
@kevinXYin , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should make sure blob cache init thread get wlock before user daemon
get first ondemand req.
Fixes: 82f6712 ("nydusd: make copen always return right file size")
Suggested-by: Jiang Liu [email protected]
Signed-off-by: Xin Yin [email protected]