Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix convert and release workflow issues #410

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Fix convert and release workflow issues #410

merged 2 commits into from
Apr 28, 2022

Conversation

bergwolf
Copy link
Member

  • workflow: only do new release upon push event
  • workflow: fix convert.yml release download URL

bergwolf added 2 commits April 28, 2022 11:02
@bergwolf
workflow: fix convert.yml release download URL
b947962 
Signed-off-by: Peng Tao <[email protected]>
@bergwolf
workflow: only do new release upon push event
92ced2f 
For other events like the scheduled one, we don't want to push anything
to the release page.

Signed-off-by: Peng Tao <[email protected]>
imeoer
imeoer approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergwolf
Copy link
Member Author

Successful runs at:
convert: https://github.com/bergwolf/image-service/actions/runs/2236895182
release: https://github.com/bergwolf/image-service/actions/runs/2236894789

@bergwolf bergwolf merged commit acaf55d into dragonflyoss:master Apr 28, 2022
@bergwolf bergwolf deleted the github/action branch April 28, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergwolf @imeoer