Nydusify: ignore arch for single manifest #359
Conversation
imeoer
force-pushed
the
fix-nydusify-arm-support
branch
from
de8842e
to
72081b6
Compare
imeoer
changed the title
| @@ -118,7 +118,7 @@ func (parser *Parser) pullIndex(ctx context.Context, desc *ocispec.Descriptor) ( | |||
| } | |||
|
|
|||
| func (parser *Parser) parseImage( | |||
| ctx context.Context, desc *ocispec.Descriptor, onlyManifest *ocispec.Manifest, | |||
| ctx context.Context, desc *ocispec.Descriptor, onlyManifest *ocispec.Manifest, ignoreArch bool, | |||
There was a problem hiding this comment.
There is no way for nydusify to specify ignoreArch?
There was a problem hiding this comment.
How is it going to be used? Please add an example in the docs.
There was a problem hiding this comment.
Updated comment. No way to specify. For a single manifest image, it's an automatic behavior to ignore the image arch for ease of use, attempt to continue converting, and give a warning message. For the manifest list, nydusify selects host specified arch to convert, but the user still can specify an interesting platform (by --platform), the ultimate goal is that nydusify/nydus-image can convert any arch's image on any arch's host.
imeoer
force-pushed
the
fix-nydusify-arm-support
branch
from
72081b6
to
c4c7909
Compare
For a single manifest image, we just ignore the arch, so that allowing to do a default conversion on a different arch's host, for example converting an arm64 image on an amd64 host. Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
fix-nydusify-arm-support
branch
from
c4c7909
to
fc07aa5
Compare
| } | ||
|
|
||
| // Just give user a simple hint telling option was ignored. | ||
| if config.Architecture != parser.interestedArch { | ||
| return nil, errors.Errorf("Specified %s architecture was not found", parser.interestedArch) | ||
| err = errors.Errorf("Found arch %s, but the specified target arch (--platform) is %s", config.Architecture, parser.interestedArch) |
There was a problem hiding this comment.
Should this be move into else{} branch?
There was a problem hiding this comment.
The same error message should be returned if no ignoreArch.
For a single manifest image, we just ignore the arch, so that allowing
to do a default conversion on a different arch's host, for example
converting an arm64 image on an amd64 host.
Signed-off-by: Yan Song [email protected]