fix some contrib projects depbot warnings #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address dependabot alerts. Signed-off-by: Peng Tao <[email protected]>
As warned by dependabot. Signed-off-by: Peng Tao <[email protected]>
jiangliu
approved these changes
Jan 19, 2022
imeoer
approved these changes
Jan 19, 2022
bergwolf
force-pushed
the
upstream/deps
branch
from
0e9eaa6 to
c9dc528
Compare
We need go 1.16+ to use go mod. Signed-off-by: Peng Tao <[email protected]>
if-return: redundant if ...; err != nil check, just return error instead Signed-off-by: Peng Tao <[email protected]>
Looks like we should just cache /go/pkkg/mod, according to Error: /go/pkg/mod/github.com/containerd/[email protected]/content/helpers.go: 232:27: undefined: io.Discard https://github.com/dragonflyoss/image-service/runs/4865967170?check_suite_focus=true Signed-off-by: Peng Tao <[email protected]>
bergwolf
force-pushed
the
upstream/deps
branch
from
c9dc528 to
9caf054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namingly we need to update containerd, image-spec and runc depenedencies for them.