snapshotter: don't touch original nydusd auth if no auth in labels #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergwolf
reviewed
Nov 19, 2021
| Password: labels[label.ImagePullSecret], | ||
| func FromLabels(labels map[string]string) *PassKeyChain { | ||
| u, found := labels[label.ImagePullUsername] | ||
| if !found { |
There was a problem hiding this comment.
should check for empty username/password as well.
There was a problem hiding this comment.
Sure. It now also checks if the values are void string.
Nydusd must pull data from registry with auth if the repo is private. Snapshotter only fetches auth from labels and if no auth in the labels, it will use empty string to replace the original auth. This causes nydusd lossing auth to access registry. Signed-off-by: Changwei Ge <[email protected]>
bergwolf
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nydusd must pull data from registry with auth if the repo is private.
Snapshotter only fetches auth from labels and if no auth in the labels,
it will use empty string to replace the original auth.
This causes nydusd lossing auth to access registry.
Signed-off-by: Changwei Ge [email protected]