storage: fix compatibility on fetching token for registry backend #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The registry backend received an unauthorized error from Harbor registry when fetching registry token by HTTP GET method, the bug is introduced from https://github.com/dragonflyoss/image-service/pull/1425/files#diff-f7ce8f265a570c66eae48c85e0f5b6f29fdaec9cf2ee2eded95810fe320d80e1L263. We should insert the basic auth header to ensure the compatibility of fetching token by HTTP GET method. This refers to containerd implementation: https://github.com/containerd/containerd/blob/dc7dba9c20f7210c38e8255487fc0ee12692149d/remotes/docker/auth/fetch.go#L187 The change has been tested for Harbor v2.9. Signed-off-by: Yan Song <[email protected]>
Regardless of whether debug compilation is enabled, we should always print error messages. Otherwise, some error logs may be lost, making it difficult to debug codes. Signed-off-by: Yan Song <[email protected]>
imeoer
requested review from
jiangliu,
gaius-qi and
hsiangkao
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
- Coverage 46.29% 46.26% -0.03%
==========================================
Files 123 123
Lines 38872 38878 +6
Branches 38872 38878 +6
==========================================
- Hits 17995 17987 -8
- Misses 19906 19918 +12
- Partials 971 973 +2
|
ccx1024cc
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The registry backend received an unauthorized error from Harbor registry
when fetching registry token by HTTP GET method, the bug is introduced
from https://github.com/dragonflyoss/image-service/pull/1425/files#diff-f7ce8f265a570c66eae48c85e0f5b6f29fdaec9cf2ee2eded95810fe320d80e1L263.
We should insert the basic auth header to ensure the compatibility of
fetching token by HTTP GET method.
This refers to containerd implementation: https://github.com/containerd/containerd/blob/dc7dba9c20f7210c38e8255487fc0ee12692149d/remotes/docker/auth/fetch.go#L187
The change has been tested for Harbor v2.9.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.