Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: fix checkout on pull_request_target #1238

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Apr 20, 2023

The pull_request_target trigger will checkout the master branch
codes strictly, but we must use the PR codes for the smoke test.

See the limitation: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

The PR also moves the performance test result to the action page, for example:

https://github.com/dragonflyoss/image-service/actions/runs/4754007981#summary-12894191943

@imeoer imeoer requested a review from a team as a code owner April 20, 2023 09:29
@imeoer imeoer requested review from bergwolf, liubogithub and jiangliu and removed request for a team April 20, 2023 09:29
@imeoer imeoer changed the title action: fix insecure action on pull_request_target [WIP] action: fix insecure action on pull_request_target Apr 20, 2023
@anolis-bot
Copy link
Collaborator

@imeoer , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69040

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1238 (ba869e6) into master (ca9f7a8) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1238   +/-   ##
=======================================
  Coverage   41.35%   41.35%           
=======================================
  Files         126      126           
  Lines       37336    37336           
  Branches    37336    37336           
=======================================
+ Hits        15440    15441    +1     
+ Misses      21164    21163    -1     
  Partials      732      732           

see 2 files with indirect coverage changes

@github-actions
Copy link

benchmark-result pull-elapsed(s) create-elapsed(s) run-elapsed(s) total-elapsed(s)
nydus-all-prefetch 0.684160 4.014606 20.181392 24.880158
nydus-filelist-prefetch 0.708450 4.091292 5.809353 10.609095
nydus-no-prefetch 1.139188 1.067884 10.768771 12.975843
oci 28.083268 0.324888 1.005102 29.413258
zran-all-prefetch 0.899922 1.903790 23.640897 26.444609

@imeoer imeoer force-pushed the fix-insecure-action-on branch from fa949be to 4bcfeaf Compare April 20, 2023 09:45
@github-actions
Copy link

benchmark-result pull-elapsed(s) create-elapsed(s) run-elapsed(s) total-elapsed(s)
nydus-all-prefetch 0.675986 2.098184 22.154187 24.928357
nydus-filelist-prefetch 0.676258 1.678898 8.833234 11.188390
nydus-no-prefetch 0.882682 0.815880 9.736755 11.435317
oci 28.877308 0.260346 1.180701 30.318355
zran-all-prefetch 0.701376 2.627872 22.600408 25.929656

@imeoer imeoer force-pushed the fix-insecure-action-on branch from 4bcfeaf to 1671b1f Compare April 20, 2023 10:04
@github-actions
Copy link

benchmark-result pull-elapsed(s) create-elapsed(s) run-elapsed(s) total-elapsed(s)
nydus-all-prefetch 0.883950 2.258536 21.782222 24.924708
nydus-filelist-prefetch 0.681408 1.844034 8.218402 10.743844
nydus-no-prefetch 0.676806 0.849800 9.761361 11.287967
oci 28.093596 0.294160 0.949783 29.337539
zran-all-prefetch 1.116124 1.918922 24.075951 27.110997

@imeoer imeoer force-pushed the fix-insecure-action-on branch from 1671b1f to 9ed45a2 Compare April 20, 2023 10:49
@github-actions
Copy link

benchmark-result pull-elapsed(s) create-elapsed(s) run-elapsed(s) total-elapsed(s)
nydus-all-prefetch 0.686336 2.567024 21.335642 24.589002
nydus-filelist-prefetch 0.689882 1.434162 8.788533 10.912577
nydus-no-prefetch 0.673996 0.714034 9.636141 11.024171
oci 28.491830 0.301822 1.057322 29.850974
zran-all-prefetch 1.091086 1.678044 24.176102 26.945232

@imeoer imeoer force-pushed the fix-insecure-action-on branch 2 times, most recently from 32f07ab to 5d1768c Compare April 20, 2023 11:05
@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

The `pull_request_target` trigger will checkout the master branch
codes by default, but we need to use the new PR codes on smoke test.

See: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer force-pushed the fix-insecure-action-on branch from 5d1768c to ba869e6 Compare April 20, 2023 12:02
@github-actions
Copy link

benchmark-result pull-elapsed(s) create-elapsed(s) run-elapsed(s) total-elapsed(s)
nydus-all-prefetch 1.104370 4.649706 20.772184 26.526260
nydus-filelist-prefetch 0.683032 1.881356 8.595420 11.159808
nydus-no-prefetch 1.106898 1.086332 10.738710 12.931940
oci 27.904678 0.308680 1.907784 30.121142
zran-all-prefetch 0.895218 1.996522 23.806309 26.698049

@imeoer imeoer changed the title [WIP] action: fix insecure action on pull_request_target [WIP] action: fix checkout on pull_request_target Apr 20, 2023
@imeoer imeoer changed the title [WIP] action: fix checkout on pull_request_target action: fix checkout on pull_request_target Apr 20, 2023
@anolis-bot
Copy link
Collaborator

@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69081

@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69082

@anolis-bot
Copy link
Collaborator

@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69083

@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@Desiki-high Desiki-high self-requested a review April 21, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants