Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scheduler/persistentcache): add uint test for host manager #3812

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes changes to the scheduler/resource/persistentcache package to ensure that time intervals are stored in nanoseconds. The most important changes include updates to the Store methods in the hostManager, peerManager, and taskManager to convert time intervals to nanoseconds.

Time interval conversion to nanoseconds:

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 10, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 10, 2025
@gaius-qi gaius-qi self-assigned this Feb 10, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 10, 2025 07:02
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.96%. Comparing base (2b75f86) to head (09b21b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/resource/persistentcache/peer_manager.go 0.00% 1 Missing ⚠️
scheduler/resource/persistentcache/task_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3812      +/-   ##
==========================================
+ Coverage   34.28%   34.96%   +0.67%     
==========================================
  Files         337      337              
  Lines       38986    38986              
==========================================
+ Hits        13365    13630     +265     
+ Misses      24776    24460     -316     
- Partials      845      896      +51     
Flag Coverage Δ
unittests 34.96% <33.33%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/persistentcache/host_manager.go 57.56% <100.00%> (+57.56%) ⬆️
scheduler/resource/persistentcache/peer_manager.go 0.00% <0.00%> (ø)
scheduler/resource/persistentcache/task_manager.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 5bf9dd1 into main Feb 10, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feature/host-manager branch February 10, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants