Uses assert_called_with instead of called_with #2375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Please check my patch. In my environment of Python3.12, an error occurs at the following line. Here is a part of the error message.
Two assertions exists at the above line. The first assertion
called_with
is called and thenassert
is called. At the first assertion, we should seem to useassert_called_with
instead ofcalled_with
. Please see:python/cpython#100690
Then, the arguments of
assert_called_with
should berequest, blocking=False
becauseKafkaClient
internally callssend
with them.https://github.com/dpkp/kafka-python/blob/master/kafka/client_async.py#L539
The second assertion should be removed because
assert
raises an error when an assert statement fails and do nothing when the statement succeeds.Thanks in advance,
Hirotaka
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)