Reduce internal client poll timeout for consumer iterator interface #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkp
changed the title
jeffwidman
approved these changes
May 29, 2019
kafka/consumer/group.py
Outdated
| @@ -1070,8 +1070,7 @@ def _message_generator(self): | |||
| self._update_fetch_positions(partitions) | |||
|
|
|||
| poll_ms = 1000 * (self._consumer_timeout - time.time()) | |||
| if not self._fetcher.in_flight_fetches(): | |||
| poll_ms = min(poll_ms, self.config['reconnect_backoff_ms']) | |||
| poll_ms = min(poll_ms, self.config['retry_backoff_ms']) | |||
There was a problem hiding this comment.
I would probably do this as a one-liner combined with the line above (https://github.com/dpkp/kafka-python/pull/1824/files#diff-9da855eb60eed8ecc72ce217c25e576cR1072)... I think it's easier to mentally think through the calculated value that way:
poll_ms = min((1000 * (self._consumer_timeout - time.time())), self.config['retry_backoff_ms'])
There was a problem hiding this comment.
I pushed this as an additional commit... feel free to either squash or if you really don't like it then just drop that particular commit.
jeffwidman
force-pushed
the
lower_consumer_timeout
branch
from
f5fddad
to
1a3d118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR attempting to address heartbeat timing issues in consumers, especially with the iterator interface. Here we can reduce the client.poll timeout to at most the retry backoff (typically 100ms) so that the consumer iterator interface doesn't block for longer than the heartbeat timeout.
This change is