Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pending completion IndexError bug caused by multiple threads #1372

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Fix pending completion IndexError bug caused by multiple threads #1372

merged 1 commit into from
Feb 8, 2018

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Feb 8, 2018

Fix #1371

jeffwidman
jeffwidman approved these changes Feb 8, 2018
View reviewed changes
Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there's no easy way to write a test for this?

@dpkp
Copy link
Owner Author

dpkp commented Feb 8, 2018

I'll put my thinking cap on re testing -- I dont have a deep bag of tricks on thread interaction testing.

@dpkp dpkp mentioned this pull request Feb 8, 2018
Closed
@dpkp dpkp merged commit 41aa034 into master Feb 8, 2018
@jeffwidman jeffwidman deleted the threadsafe_pending_responses branch February 8, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpkp @jeffwidman