Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Luau syntax highlighting #345

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Use Luau syntax highlighting #345

merged 1 commit into from
Jun 11, 2024

Conversation

Someon1e
Copy link
Contributor

No description provided.

@alexasterisk
Copy link
Contributor

Linguist is used internally by GitHub for syntax and doesn't need to be specified in the attributes of the project for it to work. You would only really see this if you had a odd / custom file extension that you wanted GitHub to treat with a certain, specified syntax.

Also, you specified the attribute as "Lua" when it should've been Luau as Linguist does support Luau.

@Someon1e
Copy link
Contributor Author

Linguist is used internally by GitHub for syntax and doesn't need to be specified in the attributes of the project for it to work. You would only really see this if you had a odd / custom file extension that you wanted GitHub to treat with a certain, specified syntax.

Also, you specified the attribute as "Lua" when it should've been Luau as Linguist does support Luau.

Hi, I believe there's a misunderstanding. I'm removing it, not adding it.

@alexasterisk
Copy link
Contributor

Yep! Seems to of been an issue with my forced dark theme plugin which made colors register incorrectly. You're right and it can be safely removed now.

@dphfox
Copy link
Owner

dphfox commented Jun 11, 2024

Nice to see it's officially supported by GitHub now - this hack has been pleasantly short lived :)

@dphfox dphfox merged commit 13f9db9 into dphfox:main Jun 11, 2024
@alexasterisk
Copy link
Contributor

As of only four days ago!
github-linguist/linguist#6612

@Someon1e Someon1e deleted the patch-1 branch June 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants