Update Fusion's CI Workflow

[krypt102]

Fixes #208
This PR updates selene to the latest version (as suggested in #208).
I've removed the Format and Unit Tests jobs as they don't seem useful anymore, however if we still need them then I can re-add them back.

[Dionysusnu]

Removing the workflows entirely was unnecessary - You could've just disabled them semi-temporarily, especially considering the intent to move the test CI outside of Roblox.

Missing the trailing newline in the file is a bit annoying for future git diffs.

Removing the pull request workflow trigger is also quite annoying because it makes the CI not act until it's already too late when a failing check would happen.

[krypt102]

Removing the pull request workflow trigger is also quite annoying because it makes the CI not act until it's already too late when a failing check would happen.

This was only done because iirc Elttob suggested to do it on the issue so we don't have two of the same action running.

In hindsight I probably should have just commented out the other 2 workflows, however from what was said in the issue itself they didn't seem useful to include. Would you mind elaborating on what "taking the CI out of Roblox" would mean?

[krypt102]

Missing the trailing newline in the file is a bit annoying for future git diffs.

Oh whoops! Didn't see this in the diff, will keep in mind!

[Dionysusnu]

Removing the pull request workflow trigger is also quite annoying because it makes the CI not act until it's already too late when a failing check would happen.

This was only done because iirc Elttob suggested to do it on the issue so we don't have two of the same action running.

That was me, but I suggested it differently. The PR trigger should be kept, alongside adding the main-branch-only condition for the push trigger.

In hindsight I probably should have just commented out the other 2 workflows, however from what was said in the issue itself they didn't seem useful to include. Would you mind elaborating on what "taking the CI out of Roblox" would mean?

Let's make a new issue for further discussion on it, but Elttob mentioned the intention to separate the unit testing into two separate parts: One that deals with Lua only, and one that includes Roblox API semantics. Once we do that, the former can then be CI tested in GitHub once again.

[krypt102]

Let's make a new issue for further discussion on it, but Elttob mentioned the intention to separate the unit testing into two separate parts

Okay! Once you've made it please mention me :D

[dphfox]

Removing the pull request workflow trigger is also quite annoying because it makes the CI not act until it's already too late when a failing check would happen.

This was only done because iirc Elttob suggested to do it on the issue so we don't have two of the same action running.

That was me, but I suggested it differently. The PR trigger should be kept, alongside adding the main-branch-only condition for the push trigger.

In hindsight I probably should have just commented out the other 2 workflows, however from what was said in the issue itself they didn't seem useful to include. Would you mind elaborating on what "taking the CI out of Roblox" would mean?

Let's make a new issue for further discussion on it, but Elttob mentioned the intention to separate the unit testing into two separate parts: One that deals with Lua only, and one that includes Roblox API semantics. Once we do that, the former can then be CI tested in GitHub once again.

To be clear btw, I didn't mean to imply that I actively intended to do this. It was more of a passing idea that we might consider in the future.

I've already been thinking about segregating Fusion along Roblox API lines so we could perhaps open up the core to other Luau environments (maybe perhaps even Lua 5.1, we'll see). None of this is an explicit intention though, more prospective stuff in my head. I'll make an issue about it if I want to present any ideas to you guys :)