fix: RepeatCount follows Roblox behaviour #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised this calculation was unneeded as the if statement that relies on numCycles will always be ignored when the RepeatCount is -1, so I reverted back to the previous fix of adding 1 to ensure 0 is properly supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggested solution for issue #172
This pull request resolves this issue by adding one to the RepeatCount and using
math.signto get the signed resultthis means that:
0 will be 1
and
-1 will be 0
I then add the absolute value of the RepeatCount onto this number, meaning
0 which was 1 will become 1
-1 which was 0 will become 1
This correctly creates the RepeatCount whilst ensuring that edge cases such as negative numbers or zero are resolved, to try to conform to the Roblox behaviour.
In order to accomplish the looping behaviour I ensure tweens that have a RepeatCount of -1 will always update their tween again by adjusting the if statement as so:
if currentTime > tween._currentTweenDuration and tween._currentTweenInfo.RepeatCount > -1 then