-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Pillow 10.0.1 #2136
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
- Coverage 79.71% 79.31% -0.40%
==========================================
Files 72 72
Lines 8990 8974 -16
==========================================
- Hits 7166 7118 -48
- Misses 1824 1856 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The reason for the failed CI runs is that Pillow >=10.0 only supports Python >= 3.8 but these CIs use Python 3.7. |
True, python 3.7 has reached it's EOL, so it's time to drop it and support 3.11 |
Good point. I opened #2147 to do just that. |
Thank you once more for #2147, let's bring this one in also |
flask_appbuilder/filemanager.py
Outdated
@@ -207,16 +207,16 @@ def resize(self, image, size): | |||
Resizes the image | |||
|
|||
:param image: The image object | |||
:param size: size is PIL tuple (width, heigth, force) ex: (200,100,True) | |||
:param size: size is PIL tuple (width, heighth, force) ex: (200,100,True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heighth -> height
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Looks good to me after the conflict is fixed |
4566f41
to
2e13b77
Compare
@dpgaspar Conflicht should be fixed now. |
Description
Pillow < 10.0.1 is affected by CVE-2023-4863, see https://pillow.readthedocs.io/en/stable/releasenotes/10.0.1.html .
ADDITIONAL INFORMATION