Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Pillow 10.0.1 #2136

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Conversation

Dosenpfand
Copy link
Contributor

Description

Pillow < 10.0.1 is affected by CVE-2023-4863, see https://pillow.readthedocs.io/en/stable/releasenotes/10.0.1.html .

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f00efc) 79.71% compared to head (a312b6a) 79.31%.
Report is 2 commits behind head on master.

❗ Current head a312b6a differs from pull request most recent head c67b9b1. Consider uploading reports for the commit c67b9b1 to get more accurate results

Files Patch % Lines
flask_appbuilder/filemanager.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2136      +/-   ##
==========================================
- Coverage   79.71%   79.31%   -0.40%     
==========================================
  Files          72       72              
  Lines        8990     8974      -16     
==========================================
- Hits         7166     7118      -48     
- Misses       1824     1856      +32     
Flag Coverage Δ
python 79.31% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dosenpfand
Copy link
Contributor Author

The reason for the failed CI runs is that Pillow >=10.0 only supports Python >= 3.8 but these CIs use Python 3.7.
What to do here? Keep using a vulnerable and unmaintained version of Pillow, clearly seems like not a solution.

@dpgaspar
Copy link
Owner

The reason for the failed CI runs is that Pillow >=10.0 only supports Python >= 3.8 but these CIs use Python 3.7. What to do here? Keep using a vulnerable and unmaintained version of Pillow, clearly seems like not a solution.

True, python 3.7 has reached it's EOL, so it's time to drop it and support 3.11

@Dosenpfand
Copy link
Contributor Author

True, python 3.7 has reached it's EOL, so it's time to drop it and support 3.11

Good point. I opened #2147 to do just that.

@dpgaspar
Copy link
Owner

Thank you once more for #2147, let's bring this one in also

@@ -207,16 +207,16 @@ def resize(self, image, size):
Resizes the image

:param image: The image object
:param size: size is PIL tuple (width, heigth, force) ex: (200,100,True)
:param size: size is PIL tuple (width, heighth, force) ex: (200,100,True)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heighth -> height

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@dpgaspar
Copy link
Owner

Looks good to me after the conflict is fixed

@Dosenpfand
Copy link
Contributor Author

@dpgaspar Conflicht should be fixed now.

@dpgaspar dpgaspar merged commit de134c0 into dpgaspar:master Feb 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants