fix: using base_filters with FilterEqualFunction not working for relation fields #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasP0815
changed the title
|
Why were all jobs canceled ? |
rerunning |
|
|
|
|
|
right! I'll do the upgrade, I'll ping you back. Thank you |
|
@ThomasP0815 got CI fixed here: #2013 |
Codecov Report
@@ Coverage Diff @@
## master #2011 +/- ##
==========================================
+ Coverage 78.46% 78.49% +0.02%
==========================================
Files 72 72
Lines 8685 8685
==========================================
+ Hits 6815 6817 +2
+ Misses 1870 1868 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dpgaspar
reviewed
Apr 21, 2023
|
@dpgaspar test added please have a look |
dpgaspar
approved these changes
Apr 28, 2023
|
LGTM, thank you once more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
issue #1745
ADDITIONAL INFORMATION
Has associated issue: