Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_bind for SQLAlchemy and Flask-SQLAlchemy #1652

Closed
wants to merge 1 commit into from

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jun 15, 2021

Description

This is still pending by Flask-SQLAlchemy latest release

Unpins SQLAlchemy below 1.4.X.

This is still pending, new SQLAlchemy 1.4.18 fixes the positional arguments on Session subclasses, but current Flask-SQLAlchemy still is not correct since it's missing the bind parameter when calling super.get_bind. Latest (yet to be released) Flask-SQLAlchemy is correct (version 3.0.0)

pallets-eco/flask-sqlalchemy#953

ADDITIONAL INFORMATION

@ashb
Copy link
Contributor

ashb commented Sep 9, 2021

Hey @dpgaspar Anything I can do to help land this? Would it be useful if I tested this change against Airflow?

@dpgaspar
Copy link
Owner Author

dpgaspar commented Sep 9, 2021

Hey @dpgaspar Anything I can do to help land this? Would it be useful if I tested this change against Airflow?

@ashb thanks for reaching out, I'm waiting for flask-sqlalchemy 3.0.0 release that would solve this, but it's taking some time. I'll revisit flask-sqlalchemy PR for 2.5.X and ask them to release a 2.5.2 (may have time next week)

https://github.com/pallets/flask-sqlalchemy/blob/main/CHANGES.rst#version-300

@ashb
Copy link
Contributor

ashb commented Sep 9, 2021

Cool. I'm just itching to start playing around with async support from SQLAlchemy 😁

@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

@stale stale bot added the stale label Mar 30, 2022
@stale stale bot closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants