[SDPA-3712] reduce js bundle size #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-yao
force-pushed
the
feature/SDPA-3712-reduce-js-bundle-size
branch
from
d4356ff to
7c1dd31
Compare
MdNadimHossain
approved these changes
Feb 13, 2020
* [SDPA-3712] Optimized lodash in webpack * [SDPA-3712] moment.js optimization (#632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-3712
Changed
this.$tideSearch) from global Vue JS instance. Which will then be loaded only on pages need it.This reduced 100KB in the initial page JS transferred size.
There is no break change added. Without that new setting, it will fallback to support
this.$tideSearchobject.Screenshots
With Search load on demand mode
Homepage JS load size(before):
Homepage JS load size(after):
With Search load on demand mode, Lodash & moment.js optimisation:
Homepage JS load size(before):
Homepage JS load size(after):
