Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix placeholder not configurable for fieldRplSelect #601

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Fix placeholder not configurable for fieldRplSelect #601

merged 4 commits into from
Nov 26, 2019

Conversation

dylankelly
Copy link
Contributor

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-

Changed

  1. Fixes placeholder not being configurable for fieldRplSelect
  2. Fixes error on click when there are no options passed to rpl-select

Screenshots

@dylankelly dylankelly requested a review from tim-yao November 20, 2019 11:56
@dylankelly dylankelly self-assigned this Nov 20, 2019
@dylankelly dylankelly changed the base branch from master to develop November 20, 2019 11:56
@dylankelly dylankelly merged commit 57f7cae into develop Nov 26, 2019
@dylankelly dylankelly deleted the feature/rpl-select-placeholder branch November 26, 2019 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-yao tim-yao tim-yao approved these changes

Assignees

@dylankelly dylankelly

Labels
Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylankelly @tim-yao