Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDPA-3390] Alerts with no link FE crash fix. #584

Merged
merged 1 commit into from
Oct 28, 2019
Merged

[SDPA-3390] Alerts with no link FE crash fix. #584

merged 1 commit into from
Oct 28, 2019

Conversation

MdNadimHossain
Copy link
Contributor

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-3390

Changed

  1. Change in plugin.js to check for null link title and link URL. At BE we made the link field for an alert not mandatory. So there will be situations when these fields can be null.

Screenshots

Screen Shot 2019-10-28 at 9 10 58 pm

@MdNadimHossain MdNadimHossain self-assigned this Oct 28, 2019
@MdNadimHossain MdNadimHossain merged commit 44b2df1 into develop Oct 28, 2019
@MdNadimHossain MdNadimHossain deleted the feature/SDPA-3390-Alerts-with-no-link-FE-crash-fix branch October 28, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-yao tim-yao tim-yao approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@MdNadimHossain MdNadimHossain

Labels
Ready for test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MdNadimHossain @tim-yao