Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPA-1576] Change placeholder colour to meet WCAG contrast. #300

Merged
merged 7 commits into from
May 27, 2019
Merged

[SDPA-1576] Change placeholder colour to meet WCAG contrast. #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55a38b6
[SDPA-15766] Change placeholder colour to meet WCAG contrast.
dylankelly Mar 15, 2019
6f86039
Set placeholder color on vue-multiselect
dylankelly Mar 26, 2019
c42c948
fix lint issue on Imagegallery
dylankelly Mar 26, 2019
6a90530
Merge branch 'master' into feature/SDPA-1576-placeholder-colour
dylankelly Mar 27, 2019
8547a18
Merge branch 'master' of github.com:dpc-sdp/ripple into feature/SDPA-…
dylankelly May 16, 2019
bb9dabc
make placeholder 011a3c
dylankelly May 16, 2019
72d4b54
Merge branch 'master' into feature/SDPA-1576-placeholder-colour
dylankelly May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/Molecules/Form/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ export default {
&__placeholder {
margin-bottom: 0;
padding: 0;
color: $rpl-form-element-placeholder-color;
}

&__single {
Expand Down
5 changes: 5 additions & 0 deletions packages/Molecules/Form/scss/_form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ $rpl-form-element-border-color: rpl-color('mid_neutral_1') !default;
$rpl-form-element-border-color-focus: rpl-color('primary') !default;
$rpl-form-element-border-radius: rem(4px) !default;
$rpl-form-element-text-color: rpl-color('extra_dark_neutral') !default;
$rpl-form-element-placeholder-color: rpl-color('extra_dark_neutral') !default;
$rpl-form-element-text-highlighted: rpl-color('secondary') !default;
$rpl-form-element-text-ruleset: ('xs', 1em, 'regular');
$rpl-form-element-padding-s-horizontal: $rpl-space-4;
Expand Down Expand Up @@ -43,6 +44,10 @@ $rpl-form-shadow: 0 2px 4px 0 rgba(0, 0, 0, .08) !default;
padding: $rpl-form-element-padding-s;
margin: 0;

&::placeholder {
color: $rpl-form-element-placeholder-color;
}

@include rpl_breakpoint(m) {
padding: $rpl-form-element-padding-m;
}
Expand Down