Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused cordova-ios import that breaks projects without ios platform #912

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

isarantis
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

What is the purpose of this PR?

In the latest version trying to build a project that has no cordova-ios platform failed with the following error:

Error: Cannot find module 'cordova-ios'
Require stack:

  • project\src-cordova\plugins\cordova-plugin-firebasex\scripts\lib\utilities.js
  • project\src-cordova\plugins\cordova-plugin-firebasex\scripts\after_prepare.js
  • C:\Users\sarantis\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\hooks\HooksRunner.js
  • C:\Users\sarantis\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\plugman\install.js
  • C:\Users\sarantis\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\plugman\plugman.js
  • C:\Users\sarantis\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\cordova-lib.js
  • C:\Users\sarantis\AppData\Roaming\npm\node_modules\cordova\src\help.js
  • C:\Users\sarantis\AppData\Roaming\npm\node_modules\cordova\src\cli.js
  • C:\Users\sarantis\AppData\Roaming\npm\node_modules\cordova\bin\cordova

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

We tested the fix with our project that failed the build state because of the require.

What testing has been done on existing functionality?

this PR does not change functionality

@dpa99c dpa99c merged commit 350289b into dpa99c:master Nov 26, 2024
@dpa99c
Copy link
Owner

dpa99c commented Nov 26, 2024

Thanks for this.
Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants