Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) fix: add FirebaseAnalytics pod #848

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jkorrek
Copy link

@jkorrek jkorrek commented Dec 5, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

What is the purpose of this PR?

Fix ios build, by adding FirebaseAnalytics pod, see #847

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Local testing of an iOS build.

@dpa99c
Copy link
Owner

dpa99c commented Dec 5, 2023

Thanks, I didn't encounter this problem while testing the v16.2.0 release but I see no harm is explicitly adding the pod so will merge this

@dpa99c dpa99c merged commit 1276830 into dpa99c:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants