Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cordova-compliant external URL handling #731

Merged
merged 2 commits into from
May 18, 2022
Merged

Cordova-compliant external URL handling #731

merged 2 commits into from
May 18, 2022

Conversation

jpike88
Copy link

@jpike88 jpike88 commented May 16, 2022 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

This PR fixes #730 by allowing CDVAppDelegate to properly capture incoming openURL events and pass them out to all plugins.

Does this PR introduce a breaking change?

  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

@jpike88 jpike88 mentioned this pull request May 16, 2022
Closed
5 tasks
@dpa99c dpa99c merged commit fa2da55 into dpa99c:master May 18, 2022
@jpike88 jpike88 deleted the patch-1 branch May 18, 2022 10:28
@lukevital lukevital mentioned this pull request Jun 2, 2022
Merged
dpa99c added a commit that referenced this pull request Aug 1, 2022
@dpa99c
(iOS) bugfix: remove openURL delegate that was erroneously re-added b…
98def34 
…y merge error.

Reimplements #731.
Will resolve #718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newer update breaks built-in Cordova handleOpenUrl passthrough
2 participants
@jpike88 @dpa99c