Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error getting the providerId that could cause getCurrentUser to fail on android #706

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

kassamina
Copy link

@kassamina kassamina commented Jan 26, 2022

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

This is to fix #662 Where getCurrentUser could fail on android

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Tested by including my fork of the plugin in our app, and getting the current user. Not just in dev but also in production.

What testing has been done on existing functionality?

The auth code has been throughly tested from tzappia's branch, but not based on your current dev build, with the other PRs recently merged. I will so some testing on it with those merged.

edit: Tested done on this branch, using the auth emulator and a pixel 6. I did not encounter any issues during testing.

Other information

@kassamina kassamina changed the title Fix android provider Fix an error getting the providerId that could cause getCurrentUser to fail on android Jan 26, 2022
@dpa99c dpa99c merged commit f297925 into dpa99c:dev Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants