Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding base class to to prevent iOS build error #579

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

stefanhk31
Copy link

PR Type

What kind of change does this PR introduce?

  • [ X ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

What is the purpose of this PR?

This is to commit the fix mentioned in #493 to the plugin directly, so that it will not need to be manually added every time a build is run.

Does this PR introduce a breaking change?

  • Yes
  • [ X ] No

Test project is currently not building for what I think are unrelated reasons:

'FirebaseCore/FirebaseCore.h' file not found.
Could not build module 'Firebase'

I have tested this fix on my own project, and it does fix the bug mentioned in #493.

@djavier
Copy link

djavier commented Feb 21, 2021

👍

@dpa99c dpa99c changed the base branch from master to dev March 18, 2021 14:07
@dpa99c dpa99c merged commit e3f41fe into dpa99c:dev Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants