Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): support for AppNotificationSettingsButton #577

Merged
merged 2 commits into from
Jun 16, 2021
Merged

(feat): support for AppNotificationSettingsButton #577

merged 2 commits into from
Jun 16, 2021

Conversation

EinfachHans
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Support for UNAuthorizationOptionProvidesAppNotificationSettings

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR is not finished yet, BECAUSE: While testing the delegate Methode wan't called when app was terminated and opened via the Button from Settings. Maybe you can have a look here?

@stale
Copy link

stale bot commented May 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 12, 2021
@EinfachHans
Copy link
Author

ping 😊

@stale stale bot removed the wontfix label May 13, 2021
@dpa99c dpa99c changed the base branch from master to dev June 16, 2021 08:16
@dpa99c dpa99c marked this pull request as ready for review June 16, 2021 08:16
@dpa99c dpa99c merged commit 2a9bf04 into dpa99c:dev Jun 16, 2021
@EinfachHans EinfachHans deleted the open-notification-settings branch June 16, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants