Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli build #527

Closed
wants to merge 2 commits into from
Closed

Cli build #527

wants to merge 2 commits into from

Conversation

boblepepeur
Copy link

@boblepepeur boblepepeur commented Sep 28, 2020

PR Type

What kind of change does this PR introduce?
I just add the feature to change the auth language of firebase
https://firebase.google.com/docs/reference/android/com/google/firebase/auth/FirebaseAuth#setLanguageCode(java.lang.String)

I also add a PR for ionic-native plugin, for test, you can use https://github.com/boblepepeur/ionic-native before they accept.

I make this PR relative to #510

  • Bugfix
  • [X ] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • [X ] Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • [X ] Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

What testing has been done on the changes in the PR?

I change local on android & IOS, every thing is working

What testing has been done on existing functionality?

Other information

@ghost
Copy link

ghost commented Sep 28, 2020

DeepCode's analysis on #b4497f found:

  • ⚠️ 3 warnings, ℹ️ 4 minor issues. 👇

Top issues

Description Example fixes
The function defined here takes 0 parameter(s), but is called here with 1 argument(s). The extra arguments will be ignored. Occurrences: 🔧 Example fixes
Use the equals method to compare strings instead of the != operator. Occurrences: 🔧 Example fixes
To provide random values, the java.util.Random object must be reused and not created for every call. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@dpa99c
Copy link
Owner

dpa99c commented Sep 29, 2020

No need to merge this PR as I'll merge your PR from master to cli_build

@dpa99c dpa99c closed this Sep 29, 2020
@boblepepeur
Copy link
Author

When do you will merge to cli_build ?

@dpa99c
Copy link
Owner

dpa99c commented Sep 30, 2020

Just merged it

@boblepepeur
Copy link
Author

Your forget to merge cordova-plugin-firebasex/www/firebase.js

:-)
Thanks for your job !

@dpa99c
Copy link
Owner

dpa99c commented Sep 30, 2020

oops, just fixed it - try now

@boblepepeur
Copy link
Author

yep its working now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants