Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct return type of a method #390

Merged
merged 1 commit into from
May 11, 2020
Merged

Fix: correct return type of a method #390

merged 1 commit into from
May 11, 2020

Conversation

TheAnkurPanchani
Copy link

PR Type

Fix of a missing return type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Just fixed a return type of method in type definition file.

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Before change, typescript compilation was failing with following error. After change compilation was successful.

Error in cordova/plugins/cordova-plugin-firebasex/types/index.d.ts(114,5):
TS7010: 'logError', which lacks return-type annotation, implicitly has an 'any' return type.

@dpa99c dpa99c merged commit 83f839f into dpa99c:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants