Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Google Tag Manager Pod for iOS #318

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Added missing Google Tag Manager Pod for iOS #318

merged 1 commit into from
Feb 28, 2020

Conversation

pjorquera
Copy link

PR Type

Added missing GoogleTagManager Cocoapods dependency (for iOS).

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Expected behaviour was having GTM support for iOS out-of-the-box.

Current PR fixes that adding missing Cocoapods dependency to plugin.xml (seamless with Android configuration).

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Creating and running iOS App with support for GTM / Google Analytics.

@ghost
Copy link

ghost commented Feb 26, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.306 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants