Added missing notification permission statuses, Provisional and Ephemeral #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
At the moment this plugin doesn't deal with two new Notification Permissions statuses that have been added to iOS in v12 ("Provisional") and v14 ("Ephemeral").
This PR updates the plugin so that it does, and it also makes the default behavior such that if you are in either of those states, it will prompt the user for notification permissions when you call
requestRemoteNotificationsAuthorization
Does this PR introduce a breaking change?
At the moment when you call
requestRemoteNotificationsAuthorization
because these two permission states are not recognized, the system prompt for notifs is not shown. This PR changes that so the prompt is shown.Happy to update the PR to make this optional or otherwise if needed.
What testing has been done on the changes in the PR?
I've tested on iOS 14.6 with the
PROVISIONAL
andNOT_DETERMINED
auth statuses, works as expected.