Changes in override, removed unnecessary lines, added missing filter …

…in query - read_only

app/presenters/tree_builder_miq_action_category.rb

@@ -4,14 +4,10 @@ class TreeBuilderMiqActionCategory < TreeBuilder
   private
 
   def override(node, object, _pid, _options)
-    img = "blank.gif"
-    leaf = !object.entries.any?
-    img = "tag.png" unless leaf
-    node[:image] = ActionController::Base.helpers.image_path("100/#{img}")
-    node[:title] = object.description
-    node[:tooltip] = _("Category: %{description}") % {:description => object.description}
+    leaf = !object.category?
+    image = leaf ? nil : "100/tag.png"
     node[:cfmeNoClick] = !leaf
-    node[:hideCheckbox] = true
+    node[:image] = image && ActionController::Base.helpers.image_path(image)
     node
   end
 
@@ -43,7 +39,7 @@ def root_options
   # Get root nodes count/array for explorer tree
   def x_get_tree_roots(count_only, _options)
     cats = Classification.categories.select(&:show)
-    cats = cats.select { |c| c.entries.any? }
+    cats = cats.select { |c| c.entries.any? && c.read_only == false }
     count_only_or_objects(count_only, cats, :description)
   end
 

spec/presenters/tree_builder_miq_action_category_spec.rb

@@ -41,22 +41,10 @@
 
   describe '#override' do
     it 'set node' do
-      desc1 = _("Category: %{description}") % {:description => tag1.description}
-      desc2 = tag1.description
       node = subject.send(:override, {}, tag1, nil, nil)
-
-      expect(node[:hideCheckbox]).to eq(true)
-      expect(node[:tooltip]).to eq(desc1)
-      expect(node[:title]).to eq(desc2)
       expect(node[:cfmeNoClick]).to eq(false)
 
-      desc1 = _("Category: %{description}") % {:description => folder1.description}
-      desc2 = folder1.description
       node = subject.send(:override, {}, folder1, nil, nil)
-
-      expect(node[:hideCheckbox]).to eq(true)
-      expect(node[:tooltip]).to eq(desc1)
-      expect(node[:title]).to eq(desc2)
       expect(node[:cfmeNoClick]).to eq(true)
     end
   end