Fix issue cursor positioning issues #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured it was related to QFont::ForceIntegerMetrics but I didn't know what to do to fix it. Thank you for the help!! |
|
Thank you. It was my two bits to help develop something I use on a daily basis... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt6 has removed
QFont::ForceIntegerMetricsfromQFont. This causes incorrect positioning of the cursor in the terminal, especially visible when the number of characters is large (typically > 30).As an alternative, we can use
QFont::PreferFullHintingto ensure all the letters are aligned properly.Another of their fixes is for "intense colors", which is also included in this PR.
PS: I have taken this from Konsole's TerminalFonts.cpp file.