Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): move the kotlin-gradle-plugin dependency into the libra… #1446

Merged

Conversation

jspizziri
Copy link
Collaborator

…ry dependencies

The kotlin-gradle-plugin dependency needs to be specified by the library so that it's not required to add it as a dependency of users projects.

@jspizziri
Copy link
Collaborator Author

jspizziri commented Mar 28, 2022

@dcvz @mpivchev,

Just a heads up for you on this. It would be great to get this into a rc release. Without this change, each user of the lib would need to modify their project build.gradle to specify the dependency at a global level.

@jspizziri
Copy link
Collaborator Author

cc @bradleyflood #1371

@bradfloodx bradfloodx requested review from dcvz and mpivchev March 28, 2022 22:55
Copy link
Contributor

@mpivchev mpivchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this :)

@mpivchev mpivchev merged commit 9289cce into doublesymmetry:feature/kotlinaudio Mar 29, 2022
@jspizziri
Copy link
Collaborator Author

@mpivchev thanks! Could we get a new RC released?

@jspizziri
Copy link
Collaborator Author

Also @dcvz @mpivchev ,

We use this project pretty heavily right now. I know everyone is busy and so I'd like to formally offer my help in maintaining the project if you'd like it. But I can certainly cut a new release myself if I had write access to the repository and npm package. If not, no big deal, just wanted to offer.

@mpivchev
Copy link
Contributor

@mpivchev thanks! Could we get a new RC released?

Will do this today :)

@mpivchev
Copy link
Contributor

Also @dcvz @mpivchev ,

We use this project pretty heavily right now. I know everyone is busy and so I'd like to formally offer my help in maintaining the project if you'd like it. But I can certainly cut a new release myself if I had write access to the repository and npm package. If not, no big deal, just wanted to offer.

We will update you on that.

@dcvz
Copy link
Contributor

dcvz commented Mar 30, 2022

rc-3 is out now incorporating this change, full change log tomorrow!

@jspizziri jspizziri mentioned this pull request Apr 13, 2022
@jspizziri jspizziri deleted the fix/kotlin-gradle-plugin branch April 29, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants