Duplicate package names #1418
Labels
Milestone
Comments
|
This issue is still open in 2.2.0-rc3 version @mpivchev can you please let me know when this can be fixed. Thanks |
|
Still facing the same issue on my end (with 2.2.0-rc3 version). |
|
Hi, currently working on #1447. I will pick this issue up after this. If one of you wants to contribute to this issue so we can get it out sooner, we would greatly appreciate it :) |
|
Thanks man, maybe changing package name solves the problem |
|
Hello @mpivchev, any update ? |
|
@hammadwahab12 It's still in our to-do list. As mentioned before, if you want this resolved quicker, you are welcome to contribute. |
This was referenced Jun 23, 2022
|
Track this PR which should ultimately resolve this issue: doublesymmetry/KotlinAudio#33 |
|
@jspizziri Thanks for all the awesome work! Is there a workaround for this currently (like downgrading) or is that PR probably coming out soon? |
|
I downgraded to 2.1.3, and it works with react-native-video v5.2.0 |
|
@stereodenis So 2.1.3 was the original version I was using before upgrading React Native but after upgrading, that version gives me a different problem (Could not find com.google.android.exoplayer:exoplayer-core:2.11.4.) which was fixed in v2.2.0-rc3. Not sure what I should do here EDIT: ended up using 2.1.3 but with this workaround: #1235 (comment) |
|
@KrisLau I have no sound in videos on android with the workaround from the comment |
|
I saw a @dcvz mentioning that you can handle resolution conflicts with gradle, so I came up with the following fix, don't know if there's a better way than replacing one by one, but anyways this works till they move away from their fork //Add this to the dependencies object in app/build.gradle
modules {
module("com.google.android.exoplayer:exoplayer") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer", "replace exoplayer with doublesymmetry.Exoplayer")
}
module("com.google.android.exoplayer:exoplayer-core") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer-core", "replace exoplayer with doublesymmetry.Exoplayer")
}
module("com.google.android.exoplayer:exoplayer-ui") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer-ui", "replace exoplayer with doublesymmetry.Exoplayer")
}
module("com.google.android.exoplayer:exoplayer-common") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer-common", "replace exoplayer with doublesymmetry.Exoplayer")
}
module("com.google.android.exoplayer:exoplayer-smoothstreaming") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer-smoothstreaming", "replace exoplayer with doublesymmetry.Exoplayer")
}
module("com.google.android.exoplayer:exoplayer-hls") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer-hls", "replace exoplayer with doublesymmetry.Exoplayer")
}
module("com.google.android.exoplayer:exoplayer-dash") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer-dash", "replace exoplayer with doublesymmetry.Exoplayer")
}
}If you have more conflicts do the following:Example of Error The conflict is with what is in the brackets (): So the conflicting module is: Resolve the conflict by adding another module to replace: module("com.google.android.exoplayer:exoplayer-datasource") {
replacedBy("com.github.doublesymmetry.Exoplayer:exoplayer-datasource", "replace exoplayer with doublesymmetry.Exoplayer")DisclaimerI only use expo-av (that also uses exo-player) for permissions and everything is working, so I'm not certain what they changed with their fork and if using this fork will break other packages |
|
@Hannes1 I added you code to android/app/build.gradle. But it is still not working. Could you please post me an example? Here's my build.gradle |
|
@DennisdeWitNL What error do you get? I don't have an example app at the momement I'll see If I have time this weekend |
There are the errors: |
|
@DennisdeWitNL Okay so you need to replace more modules because your package uses more of exoplayers modules For example You'll have to replace the following Just go through your error logs and see what yo need to replace further |
Yes, this is what I was talking about 🙂 If I remember correctly we don’t make any breaking changes in Exoplayer we just extend functionality. So things should hopefully still work if the other modules are using a version of Exoplayer not so behind the one we forked from. @jspizziri tagging you here cause this is likely something that might come up again — not sure if you were familiar with this |
|
Edit: these are all the module replaces that should avoid the duplicate classes problem |
|
@DennisdeWitNL You are probably looking at the wrong thing Example The problem isn't with So the conflicting module is: |
Hannes1
added a commit
to Hannes1/react-native-track-player
that referenced
this issue
Aug 13, 2022
|
still facing issue with [email protected] + [email protected] |
See the workaround for now @stereodenis |
|
@Hannes1 I've added only two module replacements |
|
@stereodenis mmm this might be a react native video issue, it mentions turbomodules does the package support turbomodules? Or does react native video work without react native track player changes? |
|
@Hannes1 it works for me on 6.0.0-alpha1, but not on 5.2.0 |
This was referenced Aug 16, 2022
|
If anyone needs to do this in a Managed Expo project, here's a config plugin that will replace the dependencies: I put that file in a folder called |
|
@russriser the changes that fix this are merged in doublesymmetry/KotlinAudio#38. Just need to wait for it to be included in a new version |
|
This should be fixed in 3.1.0. If you still have issues, please reopen this. |
|
@mpivchev still facing the issue in 3.2.0. |
|
+1 me too, using rntp ^3.2.0 and react-native-video ^5.2.1 . In react-native-video I had to add these two lines in settings.gradle to play my encrypted video but after these lines I am getting above conflict , RNV package is using exoplayer:2.13.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, thanks for this great library.
I am working in a project that uses a other players that use old exoplayer dependencie and I having these kind of errors:
It is because Kotlin audio is using the same "com.google.android.exoplayer2" package name, maybe could be it changed for future versions to avoid the conflict ?
Originally posted by @SystemBlad in #1264 (comment)
The text was updated successfully, but these errors were encountered: