Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring 3 + Mac #138

Merged
merged 28 commits into from
Jan 9, 2025
Merged

Spring 3 + Mac #138

merged 28 commits into from
Jan 9, 2025

Conversation

Death111
Copy link
Collaborator

@Death111 Death111 commented Jan 13, 2023 •
edited
Loading

Test-branch for a Mac M1:

  • Needs Java 17 as only Java 17 added support for Mac M2 (https://openjdk.org/jeps/391)
  • Deactivated Unit tests as they did not run. Issue was that Controller class instantiates (indirectly) a Timeline-Class (javafx class) which did not work in the pipeline. Not sure if I tested locally.
  • Switched the isLinux() calls to isWindows() as the mac does not identify as isLinux

@Death111
added javafx-graphics with mac classifier
999ae3a
@Death111
Update pom.xml
91d24aa 
try with 17.0.2 javafx (not recommended to mix with java 11 target)
@Death111
skip tests
75b81e9
@Death111 Death111 marked this pull request as draft January 13, 2023 15:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Death111 Death111 changed the title added javafx-graphics with mac classifier Spring 3 + Mac May 4, 2023
Death111
Death111 commented May 4, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
ddamke and others added 10 commits September 19, 2023 11:08
upgrade Spring Boot to 3.1.3
019ae92
checks imported h2 version is 1 oder newer
64bb287
add log statement when option is used
cc804ea
@Death111
update to latest spring patch release
1c600bd
@Death111
Merge pull request #168 from doubleSlashde/feature/update_dependencies
f3bd78e 
upgrade Spring Boot to 3.1.3
@Death111
update to javafx 22
ab2f4f0 
* https://github.com/openjdk/jfx/blob/master/doc-files/release-notes-22.md
@Death111
update git-commit plugin coordinates
39cd801 
* https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide/b7e70d3f286735f2df53fe1361dcb56e78428e84#git-commit-id-maven-plugin
@Death111
start auto save separately to fix unit test
7e113b0 
* remove no longer needed workaround dependencies
@Death111
update dependencies and move finalname to build
3c19ba2 
* fixes 'Parameter 'finalName' is read-only, must not be used in configuration'
@Death111
update github actions to latest version
9fb21c4 
* fixes warnings: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20....
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Death111
Death111 commented Apr 7, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@Death111 Death111 marked this pull request as ready for review January 8, 2025 13:37
@Death111 Death111 requested a review from sesturm January 8, 2025 13:41
sesturm added 5 commits January 8, 2025 17:42
@sesturm
Implement support for opening URLs on macOS in BrowserHelper; add isM…
2209928 
…acOS method in OS class
@sesturm
Remove TODO comment for macOS support in FileOpenHelper
109af13
@sesturm
Refactor OS class to optimize OS name retrieval
5cee4bb 
- Introduced a static final variable `OS_NAME` to store the lowercased OS name, reducing repeated calls to `System.getProperty()`.
- Updated methods `isWindows()`, `isLinux()`, `getOSName()`, and `isMacOS()` to utilize the new `OS_NAME` variable for improved performance and readability.
@sesturm
Upgrade Spring Boot and Maven Dependency Check versions in pom.xml
a783b27 
- Updated Spring Boot version from 3.1.10 to 3.4.1 for improved features and security.
- Upgraded Maven Dependency Check version from 9.1.0 to 11.1.1 to enhance dependency scanning capabilities.
@sesturm
undo version change
e87b12d
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Death111 Death111 merged commit eab713c into develop Jan 9, 2025
3 of 5 checks passed
@Death111 Death111 deleted the feature/macSupport branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesturm sesturm sesturm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Death111 @sesturm